Fix incompatability with scarpet explosion event #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this contribution. I am a bit concerned about the performance impact of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since gnembon/fabric-carpet#1937 didn't get merged for a while, here is a tricy ways of fixing the incompatability in lithium's side.
Just simply replace the
@Redirectinto@WrapOperation, and theoriginal.call()would contain the@Redirectfrom fabric-carpet. Therefore thegetExplosure()firstly goes to our wrapping, then scarpet would detect the explosion event. But if it is a duplucated explosure we would skip it, and actually from the design of scarpet it is useless to detect the explosion again (as they are the same one, just mentioned again).Tested in 1.21 with
fabric-carpet, the wrapping works and the explosion event is triggered too.